-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some example playbooks #110
Conversation
Signed-off-by: Joerg Kastning <[email protected]>
one minor nit, otherwise, lgtm |
Pull Request Test Coverage Report for Build 3636396836
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3610185788
💛 - Coveralls |
Signed-off-by: Joerg Kastning <[email protected]>
Signed-off-by: Joerg Kastning <[email protected]>
Thanks for checking the PR. I fixed the name of the task in |
Co-authored-by: Richard Megginson <[email protected]>
Sorry, I missed that second issue with the missing space. I'll do better next time by trying to use the tools at hand in a proper way. As far as I could see I hope to have catched all yamllint issues and tox shoudn't find any others. Thanks for your patience. |
Thank you for the PR! |
[1.4.1] - 2022-12-12 -------------------- ### New Features - none ### Bug Fixes - none ### Other Changes - Added some example playbooks (linux-system-roles#110) Signed-off-by: Rich Megginson <[email protected]>
[1.4.1] - 2022-12-12 -------------------- ### New Features - none ### Bug Fixes - none ### Other Changes - Added some example playbooks (#110) Signed-off-by: Rich Megginson <[email protected]> Signed-off-by: Rich Megginson <[email protected]>
Pull Request Test Coverage Report for Build 3633449436Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 3633449436Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3633449436Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
IMHO it's useful to have some example playbooks for common use cases that are easy to adapt by copy, paste, and modify.
I like it when roles have an example direktory with some playbooks in it, because it saves time when I don't have to search a long README.md for some examples.
With this PR I would like to contribute some example playbooks for the firewall role. I chose some use cases I encountered in different enviroments.
Signed-off-by: Joerg Kastning [email protected]