Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some example playbooks #110

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Added some example playbooks #110

merged 4 commits into from
Dec 7, 2022

Conversation

Tronde
Copy link
Contributor

@Tronde Tronde commented Dec 3, 2022

IMHO it's useful to have some example playbooks for common use cases that are easy to adapt by copy, paste, and modify.

I like it when roles have an example direktory with some playbooks in it, because it saves time when I don't have to search a long README.md for some examples.

With this PR I would like to contribute some example playbooks for the firewall role. I chose some use cases I encountered in different enviroments.

Signed-off-by: Joerg Kastning [email protected]

Signed-off-by: Joerg Kastning <[email protected]>
@richm
Copy link
Contributor

richm commented Dec 6, 2022

one minor nit, otherwise, lgtm

@coveralls
Copy link

coveralls commented Dec 6, 2022

Pull Request Test Coverage Report for Build 3636396836

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.919%

Totals Coverage Status
Change from base Build 3569035399: 0.0%
Covered Lines: 417
Relevant Lines: 788

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3610185788

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.919%

Totals Coverage Status
Change from base Build 3569035399: 0.0%
Covered Lines: 417
Relevant Lines: 788

💛 - Coveralls

@Tronde
Copy link
Contributor Author

Tronde commented Dec 6, 2022

Thanks for checking the PR. I fixed the name of the task in example/disable-cockpit-and-dhcpv6-client.yml as well as a yamllint error found by the tox check.

@Tronde
Copy link
Contributor Author

Tronde commented Dec 7, 2022

Sorry, I missed that second issue with the missing space. I'll do better next time by trying to use the tools at hand in a proper way. As far as I could see I hope to have catched all yamllint issues and tox shoudn't find any others. Thanks for your patience.

@richm
Copy link
Contributor

richm commented Dec 7, 2022

Sorry, I missed that second issue with the missing space. I'll do better next time by trying to use the tools at hand in a proper way. As far as I could see I hope to have catched all yamllint issues and tox shoudn't find any others. Thanks for your patience.

Thank you for the PR!

@richm richm merged commit dc3ef42 into linux-system-roles:master Dec 7, 2022
richm added a commit to richm/linux-system-roles-firewall that referenced this pull request Dec 12, 2022
[1.4.1] - 2022-12-12
--------------------

### New Features

- none

### Bug Fixes

- none

### Other Changes

- Added some example playbooks (linux-system-roles#110)

Signed-off-by: Rich Megginson <[email protected]>
richm added a commit that referenced this pull request Dec 12, 2022
[1.4.1] - 2022-12-12
--------------------

### New Features

- none

### Bug Fixes

- none

### Other Changes

- Added some example playbooks (#110)

Signed-off-by: Rich Megginson <[email protected]>

Signed-off-by: Rich Megginson <[email protected]>
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 3633449436

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.919%

Totals Coverage Status
Change from base Build 3569035399: 0.0%
Covered Lines: 417
Relevant Lines: 788

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3633449436

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.919%

Totals Coverage Status
Change from base Build 3569035399: 0.0%
Covered Lines: 417
Relevant Lines: 788

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3633449436

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.919%

Totals Coverage Status
Change from base Build 3569035399: 0.0%
Covered Lines: 417
Relevant Lines: 788

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants