-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update similarity_fn_name = 'cosine' to MaxSim #77
Comments
Hello, |
Awesome, thanks for the quick response—I'm really looking forward to it! By the way, I absolutely love this project—fantastic work! |
Thanks for the kind words! |
Sure, it works for me without any issues! |
* add dotwrapper * lint * make cleaner * add poc similarity_fn in ModelMeta * ref: rename EvaluationFunction to ScoringFunction Co-authored-by: Isaac Chung <[email protected]> * make cos_sim default * Revert "make cleaner" This reverts commit 7d1e949. * Revert "add dotwrapper" This reverts commit d71718b. * lint * fix: _run_eval no co tracking * fix: bm25s * add enum to models * add mapping st sim fn name to mteb sim fn name * fix model meta use new fn for sim operators * add max_sim * fix: colbert & rm similarity_fn_name * ci: skip AfriSentiLID for now (#1785) * skip AfriSentiLID for now * skip relevant test case instead --------- Co-authored-by: Isaac Chung <[email protected]> * test: add test for bm25s and ColBERT * lint * feat: add mapping for max_sim from pylate lightonai/pylate#77 * test: bm25s skip * fix: MaxSim as max_sim match pylate & rm Enum in models * rm enum * update tests skip --------- Co-authored-by: Roman Solomatin <[email protected]> Co-authored-by: sam021313 <[email protected]> Co-authored-by: Isaac Chung <[email protected]> Co-authored-by: Isaac Chung <[email protected]>
When loading a model, the
similarity_fn_name
attribute defaults tocosine
instead ofmax_sim
. SinceSentenceTransformer
does not supportmax_sim
natively, this functionality must be implemented usingpylate
.The text was updated successfully, but these errors were encountered: