Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer_disconnected event processing isn't robust if a peer_connected Errs #3108

Closed
TheBlueMatt opened this issue Jun 6, 2024 · 0 comments · Fixed by #3580
Closed

peer_disconnected event processing isn't robust if a peer_connected Errs #3108

TheBlueMatt opened this issue Jun 6, 2024 · 0 comments · Fixed by #3580
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@TheBlueMatt
Copy link
Collaborator

We guarantee that peer_disconnected will always be called for a peer after peer_connected, but we don't if one message handler fails peer_connected (the others wont even get it). Also, PeerManager::read_event isn't clear about if the user has to call back into PeerManager with a disconnection event (i think so, but we should check ldk-garbagecollected/ldk-c-bindings/ldk-net-tokio).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
1 participant