feat: improve resilence around tenderly call

lifinance · Jul 18, 2024 · effdb4c · effdb4c
1 parent 150daf4
commit effdb4c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/src/core/EVM/parseEVMStepErrors.ts b/src/core/EVM/parseEVMStepErrors.ts
@@ -48,7 +48,7 @@ const handleSpecificErrors = async (
 
     const errorMessage = response?.error_message
 
-    if (errorMessage.toLowerCase().includes('out of gas')) {
+    if (errorMessage?.toLowerCase().includes('out of gas')) {
       return new TransactionError(
         LiFiErrorCode.GasLimitError,
         ErrorMessage.GasLimitLow,

diff --git a/src/core/EVM/parseEVMStepErrors.unit.spec.ts b/src/core/EVM/parseEVMStepErrors.unit.spec.ts
@@ -155,12 +155,12 @@ describe('parseEVMStepErrors', () => {
   describe('when specific Errors are passed', () => {
     describe('when the error is the viem UserRejectedRequestError error', () => {
       it('should return the BaseError with the SignatureRejected code as the cause on a SDKError', async () => {
-        const MockViemError = new Error()
+        const mockViemError = new Error()
         const UserRejectedRequestError = new Error()
         UserRejectedRequestError.name = 'UserRejectedRequestError'
-        MockViemError.cause = UserRejectedRequestError
+        mockViemError.cause = UserRejectedRequestError
 
-        const parsedError = await parseEVMStepErrors(MockViemError)
+        const parsedError = await parseEVMStepErrors(mockViemError)
 
         expect(parsedError).toBeInstanceOf(SDKError)
 
@@ -179,7 +179,7 @@ describe('parseEVMStepErrors', () => {
         error_message: 'out of gas',
       })
 
-      const MockTransactionError = new TransactionError(
+      const mockTransactionError = new TransactionError(
         LiFiErrorCode.TransactionFailed,
         ErrorMessage.TransactionReverted
       )
@@ -196,7 +196,7 @@ describe('parseEVMStepErrors', () => {
       } as Process
 
       const parsedError = await parseEVMStepErrors(
-        MockTransactionError,
+        mockTransactionError,
         mockStep,
         mockProcess
       )
@@ -207,7 +207,7 @@ describe('parseEVMStepErrors', () => {
       expect(baseError).toBeInstanceOf(TransactionError)
       expect(baseError.code).toEqual(LiFiErrorCode.GasLimitError)
       expect(baseError.message).toEqual(ErrorMessage.GasLimitLow)
-      expect(baseError.cause).toBe(MockTransactionError)
+      expect(baseError.cause).toBe(mockTransactionError)
 
       vi.clearAllMocks()
     })

diff --git a/src/helpers.ts b/src/helpers.ts
@@ -65,10 +65,12 @@ export const convertQuoteToRoute = (step: LiFiStep): Route => {
 }
 
 export const fetchTxErrorDetails = async (txHash: string, chainId: number) => {
-  const response = await fetch(
-    `https://api.tenderly.co/api/v1/public-contract/${chainId}/tx/${txHash}`
-  )
-  const reponseBody = await response.json()
+  try {
+    const response = await fetch(
+      `https://api.tenderly.co/api/v1/public-contract/${chainId}/tx/${txHash}`
+    )
+    const reponseBody = await response.json()
 
-  return reponseBody
+    return reponseBody
+  } catch (_) {}
 }