Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In flock.midi.connectionView and other components, ensure listeners are bound to its underlying connection, not directly shared #32

Open
colinbdclark opened this issue Nov 29, 2020 · 1 comment

Comments

@colinbdclark
Copy link
Contributor

As pointed out by @amb26 in reviewing the pull request for #30, we shouldn't be directly sharing events between components, we should be binding listeners between them instead.

@colinbdclark
Copy link
Contributor Author

It looks like this is a common practice throughout the library, and needs to be addressed in:

  • flock.midi.controller
  • flock.midi.connectorView
  • flock.midi.portSelectorView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant