You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that I have a device that supports polyphonic aftertouch, I discovered that while incoming polyphonic aftertouch messages correctly use "pressure", outgoing messages must use "velocity" so that the value survives its trip through flock.midi.write.note:
After a further conversation with @the-t-in-rtf, it sounds like the issue is that when we are trying to encode an outgoing polyphonic aftertouch message, Flocking's implementation erroneously reuses the writer function for note messages, which expect to read and encode a velocity property, which isn't appropriate for polyphonic aftertouch messages (which need to encode the pressure property).
Here's the implementation of
flock.midi.write.note. To fix this issue, we should simply ensure that the line that @the-t-in-rtf provides above does not reuse the note writer, but instead makes a call directly to flock.midi.write.threeByteMessage.
@the-t-in-rtf, if you've got a fix for this, a PR here is fine and then eventually we'll start the work of forward-porting everything to flocking-midi (which hasn't been looked at in a couple years, needs to be de-Nodeified and then finished.
Now that I have a device that supports polyphonic aftertouch, I discovered that while incoming polyphonic aftertouch messages correctly use "pressure", outgoing messages must use "velocity" so that the value survives its trip through flock.midi.write.note:
https://github.com/colinbdclark/Flocking/blob/master/src/web/midi.js#L613
The text was updated successfully, but these errors were encountered: