This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: ping old DHT peers before eviction #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the DHT contact logic to ping the old peers when buckets are full and only evict if the peer does not respond.
…eers-before-eviction
|
Going to merge this as further refactoring is necessary as part of #233 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the DHT contact logic to ping the old peers when buckets are full and only evict if the peer does not respond.
Runs ping requests in a queue to prevent flooding the network if lots and lots of peers are added very quickly.
Uses the generic libp2p ping, rather than the DHT RPC ping, I'm not sure if this is correct. It looks like
go-libp2p-kad-dhtjust tries to dial the remote peer and treats that as success, so maybe this should just do that?