Missing BUILD_AS_WORKER parameter

[cawa-93]

It seems here was missing BUILD_AS_WORKER and ENVIRONMENT=worker.

JavascriptSubtitlesOctopus/Makefile

Lines 306 to 313 in 8309002

	mkdir -p dist/js
	emcc src/subtitles-octopus-worker.bc $(OCTP_DEPS) \
	--pre-js src/pre-worker.js \
	--pre-js src/unbrotli.js \
	--post-js src/SubOctpInterface.js \
	--post-js src/post-worker.js \
	-s WASM=1 \
	$(EMCC_COMMON_ARGS)

[TheOneric]

ENVIRONMENT=worker apparently was implied (with our other settings) in prior versions of emscripten, with the next emscripten bump it’ll be made explicit.

The BUILD_AS_WORKER documentation you’re linking is specific to emscripten_create_worker(…) which we do not use. Is there any documentation that this is a more general setting and if so what is the difference to ENVIRONMENT=worker?

[TheOneric]

ENVIRONMENT=worker was now added explicitly. As noted, BUILD_AS_WORKER appears to only apply to a emscripten-specific worker API not used by us, so probably not required. If that's incorrect, don't hesitate to point out why it should be set.