Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player initialization stalls when fetch for wasm file fails #85

Closed
nickfujita opened this issue Feb 17, 2021 · 2 comments
Closed

Player initialization stalls when fetch for wasm file fails #85

nickfujita opened this issue Feb 17, 2021 · 2 comments
Labels

Comments

@nickfujita
Copy link
Contributor

There is a missing case in the emscripten module fails to fetch the wasm file. Once the following PR is merged and released, we can update the emscripten version to resolve this:
emscripten-core/emscripten#13516

@TheOneric
Copy link
Member

TheOneric commented Jul 30, 2021

@nickfujita Can you elaborate on what you think should happen and why?
Perhaps I'm missing something, but it seems to me there just isn't much that can be done if fetching the wasm-binary fails; it is crucial for the the functionality. There is no way to operate without successfully loading (one of the two) "binaries". If fetching fails, JSO must abort.
In theory it would be possible to retry with the non-wasm-"binary", but at first glance this doesn't appear to me as being really helpful: Either there's a problem with the network and fetching the other "binary" will (very likely) fail as well, or the server is misconfigured and only allows fetching/hosts the non-wasm-binary, in which case this would only mask a server-side error.

@TheOneric
Copy link
Member

Closing due to inactivity by OP. Can be reopened if OP responds with an explanation of the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants