Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy worker script fails to run #117

Closed
nopol10 opened this issue Jan 3, 2022 · 1 comment
Closed

Legacy worker script fails to run #117

nopol10 opened this issue Jan 3, 2022 · 1 comment

Comments

@nopol10
Copy link

nopol10 commented Jan 3, 2022

I'm currently using Subtitle Octopus in a browser extension to overlay .ass subs on top of videos on sites such as YouTube. It works well when WASM isn't blocked by the site's content security policy.
However when the site's CSP prevents WASM code generation, the legacy worker script will be used.

The legacy script throws the following error during initialization:

I've made some modifications to how fonts are loaded to make it work in the context of an extension, but they are the same as what was done to the non-legacy script which works fine after the changes so I don't think this is due to my modifications. The large line numbers are due to me running prettier on the file.

The error above happens for the 4.0.0 subtitles-octopus-worker-legacy.js. If I build the latest source, a similar error occurs but during _emscripten_bind_SubtitleOctopus_initLibrary_2 instead of _emscripten_bind_SubtitleOctopus_createTrack_1

I probably have a workaround for this that does not involve falling back on the legacy script but I just want to know if this is something that can be solved or if the legacy script is not supported any more.

@nopol10
Copy link
Author

nopol10 commented Jan 3, 2022

I'm an idiot, it is my mistake 😅

@nopol10 nopol10 closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant