Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future fontconfig versions ⪈2.13.94 won't need the fcstat patch #103

Closed
vadimkantorov opened this issue Jun 19, 2021 · 2 comments
Closed
Labels

Comments

@vadimkantorov
Copy link

I found they have an accessible bug tracker at https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues and was thinking to report it there

https://github.com/libass/JavascriptSubtitlesOctopus/blob/master/build/patches/fontconfig/0003-fix-fcstats-emscripten.patch

I'm using your patch for compiling TexLive under emscripten: https://github.com/busytex/busytex/blob/main/fontconfig_emcc.patch . Thanks for your patch!

@vadimkantorov
Copy link
Author

I submitted an issue to fontconfig and they fixed the fcstats problem.

@TFSThiagoBR98 could you please drop in https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/282 and add your viewpoint about remaining problems or any advices of setting up official CI test or official instructions of building fontconfig/freetype for WASM? Thanks :)

@TheOneric TheOneric changed the title Is fontconfig patch still needed with recent emscripten+fontconfig? Future fontconfig versions ⪈2.13.94 won't need the fcstat patch Oct 18, 2021
@TheOneric TheOneric mentioned this issue Mar 27, 2022
4 tasks
TheOneric added a commit to TheOneric/JavascriptSubtitlesOctopus that referenced this issue Apr 2, 2022
Together with the prior emscripten bump,
this removes the need for the fcstat patch.
Closes: libass#103
TheOneric added a commit to TheOneric/JavascriptSubtitlesOctopus that referenced this issue Apr 7, 2022
Together with the prior emscripten bump,
this removes the need for the fcstat patch.
Closes: libass#103
TheOneric added a commit to TheOneric/JavascriptSubtitlesOctopus that referenced this issue May 21, 2022
Together with the prior emscripten bump,
this removes the need for the fcstat patch.
Closes: libass#103
@TheOneric
Copy link
Member

Thanks @vadimkantorov for looking into this and contacting Fontconfig! As it turned out though, the version of emscripten we previously used, had a linker bug which made it not work even after the fix at Fontconfig’s side, but this should now be sorted out after upgrading emscripten.

dmitrylyzo pushed a commit to dmitrylyzo/JavascriptSubtitlesOctopus that referenced this issue Dec 12, 2022
Together with the prior emscripten bump,
this removes the need for the fcstat patch.
Closes: libass#103

Cherry-picked from: libass@7250e6e
dmitrylyzo pushed a commit to dmitrylyzo/JavascriptSubtitlesOctopus that referenced this issue Dec 22, 2022
Together with the prior emscripten bump,
this removes the need for the fcstat patch.
Closes: libass#103

Cherry-picked from: libass@7250e6e
dmitrylyzo pushed a commit to dmitrylyzo/JavascriptSubtitlesOctopus that referenced this issue Dec 22, 2022
Together with the prior emscripten bump,
this removes the need for the fcstat patch.
Closes: libass#103

Cherry-picked from: libass@7250e6e
dmitrylyzo pushed a commit to dmitrylyzo/JavascriptSubtitlesOctopus that referenced this issue Dec 23, 2022
Together with the prior emscripten bump,
this removes the need for the fcstat patch.
Closes: libass#103

Cherry-picked from: libass@7250e6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants