Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons overridden by extensions that contribute language icons #10

Open
kimagin opened this issue Jul 2, 2024 · 3 comments
Open

icons overridden by extensions that contribute language icons #10

kimagin opened this issue Jul 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@kimagin
Copy link

kimagin commented Jul 2, 2024

Thank you very much for the beautiful Icons.

While, everything looks elegance, the .astro file icons appear in color and they become distracting.

Thank you for your attention to this issue.

@lewxdev lewxdev added the bug Something isn't working label Jul 8, 2024
@lewxdev
Copy link
Owner

lewxdev commented Jul 8, 2024

@kimagin thanks for submitting this issue. I noticed this too, but I'm not sure the best way to resolve it.

it seems like this happens when extensions that add contributes.languages[].icon seem to override the icon theme (in this case Astro). is this what you're seeing? I also noticed this with Cucumber (Gherkin) Full Support for .feature files

Screenshot 2024-07-08 at 09 51 26 Screenshot 2024-07-08 at 10 09 52

@lewxdev lewxdev changed the title fix: Icon for .astro files is in color icons overridden by third-party extensions that contribute language icons Jul 8, 2024
@lewxdev lewxdev changed the title icons overridden by third-party extensions that contribute language icons icons overridden by extensions that contribute language icons Jul 8, 2024
@lewxdev lewxdev pinned this issue Jul 8, 2024
@kimagin
Copy link
Author

kimagin commented Jul 9, 2024

Hello,

I've tried my self to find the JSON file containing all the Icon sets inside the extension folder and added a new .astro to the object. Then I've used a black and white version of Astro icon from Iconify and added it to the JSON object and it worked fine. Having said that, this should be implemented from your side, otherwise every time that I install the extension, I have to do it manually. Hope this will be helpful.

@lewxdev
Copy link
Owner

lewxdev commented Jul 10, 2024

kicking myself for just discovering "showLanguageModeIcons":false.
@kimagin, this should be fixed next release 🙌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants