Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android. OS 7. Split mode. App crashes with split mode #18

Open
danylopidhainyi23 opened this issue Dec 8, 2016 · 4 comments
Open

Android. OS 7. Split mode. App crashes with split mode #18

danylopidhainyi23 opened this issue Dec 8, 2016 · 4 comments

Comments

@danylopidhainyi23
Copy link

danylopidhainyi23 commented Dec 8, 2016

Device: Nexus 5X, OS 7.0

There are 2 ways to reproduce it:

1

  • Launch app
  • Open Events screen (Session, BoFs, Social events)
  • Activate split mode
  • Actual: Crash

2

  • Launch app
  • Open any screen ecxept Events
  • Activate split mode
  • Change device position to landskape
  • Actual: Crash

Crash log attached:
12-01 15:59:27.611: E/AndroidRuntime(19996): FATAL EXCEPTION: main
12-01 15:59:27.611: E/AndroidRuntime(19996): Process: com.ls.drupalconapp, PID: 19996
12-01 15:59:27.611: E/AndroidRuntime(19996): java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.SharedPreferences android.content.Context.getSharedPreferences(java.lang.String, int)' on a null object reference
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.model.PreferencesManager.(PreferencesManager.java:29)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.model.PreferencesManager.create(PreferencesManager.java:23)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.utils.DateUtils.getTimeZone(DateUtils.java:18)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.utils.DateUtils.isToday(DateUtils.java:38)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.ui.fragment.EventHolderFragment.switchToCurrentDay(EventHolderFragment.java:272)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.ui.fragment.EventHolderFragment.updateViews(EventHolderFragment.java:266)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.ui.fragment.EventHolderFragment.access$300(EventHolderFragment.java:38)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.ui.fragment.EventHolderFragment$LoadData.onPostExecute(EventHolderFragment.java:193)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.connfa.ui.fragment.EventHolderFragment$LoadData.onPostExecute(EventHolderFragment.java:184)
12-01 15:59:27.611: E/AndroidRuntime(19996): at android.os.AsyncTask.finish(AsyncTask.java:660)
12-01 15:59:27.611: E/AndroidRuntime(19996): at android.os.AsyncTask.-wrap1(AsyncTask.java)
12-01 15:59:27.611: E/AndroidRuntime(19996): at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:677)
12-01 15:59:27.611: E/AndroidRuntime(19996): at android.os.Handler.dispatchMessage(Handler.java:102)
12-01 15:59:27.611: E/AndroidRuntime(19996): at android.os.Looper.loop(Looper.java:154)
12-01 15:59:27.611: E/AndroidRuntime(19996): at android.app.ActivityThread.main(ActivityThread.java:6077)
12-01 15:59:27.611: E/AndroidRuntime(19996): at java.lang.reflect.Method.invoke(Native Method)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
12-01 15:59:27.611: E/AndroidRuntime(19996): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

@rock3r
Copy link

rock3r commented Jan 14, 2017

I have observed some concerning behaviour with regards to split screen mode:

split

If you don't cancel the splitscreen selection as shown above (i.e., you select the secondary window, then close splitscreen mode), then the behaviour does not happen.

@TarasKunyk
Copy link
Member

Hello,
App wasn't designed to support split screen mode (since it was added in Nougat). So this feature was never tested.
So we have two options to resolve this issue:

  • Spend unpredictable amount of time testing all screens and resolving issues (Which is more accurate but time-consuming approach)
  • Just disable split screen mode using android:resizeableActivity = false flag

@rock3r
Copy link

rock3r commented Jan 16, 2017

Well if an app is well designed it should work -- or almost work -- out of the box in split screen mode (usually the only thing you need to do is move code from onResume/onPause to onStart/onStop). I'm looking into solving the problem at the root, currently. In the meantime I'll add the resizeableActivity attribute, but that's just a workaround

@developerRojina
Copy link

You can have a look at this:
wix/react-native-navigation#2191 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants