Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can select 'wrong' folder #10

Open
ConfusedVorlon opened this issue Jun 1, 2020 · 1 comment
Open

User can select 'wrong' folder #10

ConfusedVorlon opened this issue Jun 1, 2020 · 1 comment

Comments

@ConfusedVorlon
Copy link

I just noticed this in my swift fork.
If the user uses the recents dropdown in the file picker, then they can select a folder which is not the requested one.
This causes an incorrect 'true' return in the requestPermission flow

My fix is to double-check on select

https://github.com/ConfusedVorlon/SwiftySandboxFileAccess/blob/2.0.0/SwiftySandboxFileAccess/Classes/SandboxFileAccessOpenSavePanelDelegate.swift

see: func panel(_ sender: Any, validate url: URL) throws

@leighmcculloch
Copy link
Owner

Nice catch, thanks for picking up on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants