Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot parse integer from empty string error #1

Closed
timmerk opened this issue Jan 26, 2022 · 2 comments
Closed

Cannot parse integer from empty string error #1

timmerk opened this issue Jan 26, 2022 · 2 comments
Assignees
@lefth

Comments

@timmerk
Copy link

timmerk commented Jan 26, 2022

./subtitle-adjust --offset -68 --offset-start 18:11:18 subs.srt
Error: Error processing subtitles

Caused by:
cannot parse integer from empty string

subs.txt
Note, I renamed the filename to .txt instead of .srt since Github wouldn't let me upload a .srt file.
The file has Unix style line endings, and running subtitle-adjust on a M1 Silicon Macbook under Mac OS 12.
@timmerk
Copy link
Author

timmerk commented Jan 26, 2022 •
edited
Loading

The problem seems to be timestamps with ",000". Once I replaced those with ",001", the program ran and exported a new srt file.

@lefth lefth self-assigned this Jan 27, 2022
lefth added a commit that referenced this issue Jan 27, 2022
@lefth
Fix number parsing of "n.000" and "n,000", and add a test for this case
545fc4b 
This fixes issue #1.
@lefth
Copy link
Owner

lefth commented Jan 27, 2022

Thanks @timmerk! I just pushed the fix as commit 545fc4b.

@lefth lefth closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lefth lefth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timmerk @lefth