Replies: 1 comment 2 replies
-
Added this to the main branch. Thanks. We we tinkering with the
teleconference a few years back to make it look more like an IRC chat room,
but then gave up as no on seemed to use it. Feel free to keep sending
those fixes you spot! Thanks!
…On Tue, Sep 10, 2024 at 12:06 PM Robert Cadena ***@***.***> wrote:
Having not had a multimode bbs before, nor used RG teleconference much, I
might be off about how this is supposed to work.
Summary: the /U (show users in room) doesn't show anything if there is
more than one user in the room.
The way I expect it to work, of course, is that any user in the room
should show up in the list.
Here's a video of how it's working on two nodes, compiled on the HEAD of
main.
teleconf-users.gif (view on web)
<https://github.com/user-attachments/assets/19f3c55c-407c-47eb-b2c0-018600062bbd>
The fix is simple
<https://github.com/leewoodridge/RenegadeBBS/compare/main...rcadena:RenegadeBBS:teleconf-show-users?expand=1>:
the check in ShowRoom only goes into the loop to show the users if People
= 0, so just make it check for not zero.
Here's my branch with the fix.
teleconf-fix.gif (view on web)
<https://github.com/user-attachments/assets/a4d8771d-2669-44ef-b70e-7e5bc1d78705>
—
Reply to this email directly, view it on GitHub
<#4>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2LMU62NHLQ5HX3GRUGLADZV4KJZAVCNFSM6AAAAABN7DFUWSVHI2DSMVQWIX3LMV43ERDJONRXK43TNFXW4OZXGE3DKNBSGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Having not had a multimode bbs before, nor used RG teleconference much, I might be off about how this is supposed to work.
Summary: the /U (show users in room) doesn't show anything if there is more than one user in the room.
The way I expect it to work, of course, is that any user in the room should show up in the list.
Here's a video of how it's working on two nodes, compiled on the HEAD of main.
![teleconf-users](https://private-user-images.githubusercontent.com/73070/366117543-19f3c55c-407c-47eb-b2c0-018600062bbd.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ2NjcsIm5iZiI6MTczOTA5NDM2NywicGF0aCI6Ii83MzA3MC8zNjYxMTc1NDMtMTlmM2M1NWMtNDA3Yy00N2ViLWIyYzAtMDE4NjAwMDYyYmJkLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDA5NDYwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2YjM0ZDcyNjg4MzgyN2Y2YWU5M2FkMjNlZTZkZjdlNTljOTNkNTZlMTMxMjMyNTI2MzRlZDVlMDFiNDE2YWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.RWKNvTEd53olJlOJBcAH8TX8QwDTCoRXr1OHJC3mbZU)
The fix is simple: the check in ShowRoom only goes into the loop to show the users if
People = 0
, so just make it check for not zero.Here's my branch with the fix.
![teleconf-fix](https://private-user-images.githubusercontent.com/73070/366119055-a4d8771d-2669-44ef-b70e-7e5bc1d78705.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwOTQ2NjcsIm5iZiI6MTczOTA5NDM2NywicGF0aCI6Ii83MzA3MC8zNjYxMTkwNTUtYTRkODc3MWQtMjY2OS00NGVmLWI3MGUtN2U1YmMxZDc4NzA1LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDA5NDYwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFkOTU1YmYwZGVkYjE2YjA3ZTdkOGEyNWFjZDE0M2UxNjY3MGNkMzMzYzNhMjRjNDlmYzA0MmI4YmY0ZDUwYzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.MZeaAEzq0oLfn0QCWA5GOtxppuDfqwYVxSPm4NTUMgU)
Beta Was this translation helpful? Give feedback.
All reactions