Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more granular minimum and maximum fees per transaction type #639

Open
314159265359879 opened this issue Nov 20, 2024 · 3 comments
Open

Comments

@314159265359879
Copy link

This will introduce a fixed fee (low, medium and high) for STX transactions to prevent users from overpaying by using the default options in Leather.
#600

This contains the current min/max fees in case the fee estimator gives us a higher value and suggestion for new min/max values per setting (low, medium, high) and transaction type (STX transfer, Contract call or Contract deployment):
https://docs.google.com/spreadsheets/d/1SVtbuEtUjAvYdnbR-5bDch9wCMrkv7t4VDCZK5T0JYY/edit?gid=0#gid=0

A couple more notes:
There may be better solutions, especially for contract calls and contract deployments. There is a lot more variation, and some require more of the block budget than others. That is currently not reflected by these flat fee rates (although the fee estimator API does factor this in), In the long term, a solution based on uSTX/%block could be used to make better judgements.

Or a solution like this: hirosystems/stacks-blockchain-api#2172. If we use a modifier like that, we can possibly use more lenient maximums. If the modification factor is applied first and still turns out higher than the maximum, we can still cap it there to avoid surprises seen in the past of users unknowingly setting a 500 STX fee (because it was the "normal" option served by the wallet).

Copy link

linear bot commented Nov 20, 2024

Copy link
Collaborator

camerow commented Nov 21, 2024

Added this to the next cycle, though we will need some design eyes on this. @michelly / @fabric-8

Copy link

Hm I'm not sure why this would require design when it's basically just a change to our default fee values?

@camerow camerow added extension enhancement New feature or request enhancement-p2 labels Jan 7, 2025 — with Linear
@camerow camerow removed the extension label Jan 7, 2025
@camerow camerow added the extension label Jan 7, 2025 — with Linear
@camerow camerow removed the enhancement New feature or request label Jan 7, 2025
@camerow camerow added the enhancement New feature or request label Jan 7, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants