From 45064fe95651e8045ff13aa8a3623909536e64b7 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Jul 2024 07:20:13 +0200 Subject: [PATCH 1/4] GitHub Actions: Fix hendrikmuhs/ccache miss on Build Jupyter Kernel The GitHub Action [`hendrikmuhs/ccache-action`](https://github.com/hendrikmuhs/ccache-action) is used 8 times and most jobs successfully use that cache. However, 2 jobs raise cache miss warnings at the bottom right of https://github.com/lcompilers/lpython/actions/runs/9861518999 ``` Save cache using key "sccache-build_jupyter_kernel--2024-07-11T04:38:05.880Z". Warning: Saving cache failed: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. ``` This pull request attempts to fix the cache miss on the `Build Jupyter Kernel` job. @hendrikmuhs Your review, please. --- .github/workflows/CI.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4a321f00e7..9968939c17 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -527,7 +527,9 @@ jobs: -DWITH_LLVM=yes \ -DWITH_XEUS=yes \ -DCMAKE_PREFIX_PATH="$CONDA_PREFIX" \ - -DCMAKE_INSTALL_PREFIX="$CONDA_PREFIX" + -DCMAKE_INSTALL_PREFIX="$CONDA_PREFIX" \ + -DCMAKE_C_COMPILER_LAUNCHER=ccache \ + -DCMAKE_CXX_COMPILER_LAUNCHER=ccache ninja install ctest --output-on-failure From 0e9c4e2afa0fa6d88ba02e8a04128bb6ea39b756 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Jul 2024 07:34:16 +0200 Subject: [PATCH 2/4] create-symlink: true --- .github/workflows/CI.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 9968939c17..f0f060e0ee 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -514,6 +514,7 @@ jobs: - uses: hendrikmuhs/ccache-action@main with: + create-symlink: true variant: sccache key: ${{ github.job }}-${{ matrix.os }} From 59f5c969aa37e3aac06723a0602a34734627ea2e Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Jul 2024 07:42:48 +0200 Subject: [PATCH 3/4] variant: sccache --- .github/workflows/CI.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index f0f060e0ee..c267620402 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -132,7 +132,7 @@ jobs: - uses: hendrikmuhs/ccache-action@main with: - variant: sccache + # variant: sccache key: ${{ github.job }}-${{ matrix.os }} - name : Remove existing node @@ -514,7 +514,6 @@ jobs: - uses: hendrikmuhs/ccache-action@main with: - create-symlink: true variant: sccache key: ${{ github.job }}-${{ matrix.os }} @@ -529,8 +528,8 @@ jobs: -DWITH_XEUS=yes \ -DCMAKE_PREFIX_PATH="$CONDA_PREFIX" \ -DCMAKE_INSTALL_PREFIX="$CONDA_PREFIX" \ - -DCMAKE_C_COMPILER_LAUNCHER=ccache \ - -DCMAKE_CXX_COMPILER_LAUNCHER=ccache + -DCMAKE_C_COMPILER_LAUNCHER=sccache \ + -DCMAKE_CXX_COMPILER_LAUNCHER=sccache ninja install ctest --output-on-failure From 58c266ea1e09d31cbffb54087977758657779997 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Jul 2024 10:32:10 +0200 Subject: [PATCH 4/4] GitHub Actions: Fix hendrikmuhs/ccache miss --- .github/workflows/CI.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index c267620402..b920ba32ae 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -132,7 +132,6 @@ jobs: - uses: hendrikmuhs/ccache-action@main with: - # variant: sccache key: ${{ github.job }}-${{ matrix.os }} - name : Remove existing node