Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASR: bettern argument names for StringContains #2786

Closed
certik opened this issue Jul 25, 2024 · 1 comment · Fixed by #2806
Closed

ASR: bettern argument names for StringContains #2786

certik opened this issue Jul 25, 2024 · 1 comment · Fixed by #2806
Labels
easy to fix

Comments

@certik
Copy link
Contributor

certik commented Jul 25, 2024

Currently the ASDL definition is:

StringContains(expr left, expr right, ttype type, expr? value)

And we should rename left to substr and right to str.
@Ayush-Devs
Copy link
Contributor

I would like to work on this.

@Ayush-Devs Ayush-Devs mentioned this issue Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better argument names for StringContains Ayush-Devs/lpython
2 participants
@certik @Ayush-Devs