Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LLVM code generation error in List comparsion #2697

Merged
merged 2 commits into from
May 12, 2024
Merged

Fix LLVM code generation error in List comparsion #2697

merged 2 commits into from
May 12, 2024

Conversation

hankluo6
Copy link
Contributor

Fixes: #2676

There was an issue where builder0 and builder shared the same insertion point. As a result, builder0 would append alloca instruction after instructions created by builder.

Shaikh-Ubaid
Shaikh-Ubaid approved these changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Shaikh-Ubaid Shaikh-Ubaid enabled auto-merge May 12, 2024 02:45
@Shaikh-Ubaid Shaikh-Ubaid merged commit 21e27d8 into lcompilers:main May 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaikh-Ubaid Shaikh-Ubaid Shaikh-Ubaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Comparing lists using the == and != operators leads to an LLVM code generation error
2 participants
@hankluo6 @Shaikh-Ubaid