Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Support string repeat with a non-constant integer #2652

Closed
kmr-srbh opened this issue Apr 15, 2024 · 1 comment · Fixed by #2675
Closed

Improvement: Support string repeat with a non-constant integer #2652

kmr-srbh opened this issue Apr 15, 2024 · 1 comment · Fixed by #2675

Comments

@kmr-srbh
Copy link
Contributor

from lpython import i32

my_string: str = "#"
n: i32 = 5

print(my_string * n)
(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
Internal Compiler Error: Unhandled exception
Traceback (most recent call last):
.
.
.
  File "/home/saurabh-kumar/Projects/System/lpython/src/lpython/semantics/python_ast_to_asr.cpp", line 3462, in LCompilers::LPython::CommonVisitor<LCompilers::LPython::BodyVisitor>::visit_BinOp(LCompilers::LPython::AST::BinOp_t const&)
    make_BinOp_helper(left, right, op, x.base.base.loc);
  File "/home/saurabh-kumar/Projects/System/lpython/src/lpython/semantics/python_ast_to_asr.cpp", line 2055, in LCompilers::LPython::CommonVisitor<LCompilers::LPython::BodyVisitor>::make_BinOp_helper(LCompilers::ASR::expr_t*, LCompilers::ASR::expr_t*, LCompilers::ASR::binopType, LCompilers::Location const&)
    right_int = ASR::down_cast<ASR::IntegerConstant_t>(
AssertFailed: f != nullptr
@Shaikh-Ubaid
Copy link
Collaborator

After supporting this feature, also refactor https://github.com/lcompilers/lpython/pull/2651/files#r1573132771 to simply use * operator instead of the for loops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants