Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --show-asr output #2622

Closed
wants to merge 1 commit into from
Closed

Conversation

kmr-srbh
Copy link
Contributor

fixes #2621

@kmr-srbh
Copy link
Contributor Author

kmr-srbh commented Mar 23, 2024

@Shaikh-Ubaid passing by reference should have solved the issue with this, but it does not work. Could you please look into it? What are we missing?

@Shaikh-Ubaid
Copy link
Collaborator

Please see #2621 (comment). I think this PR would not be needed. I am marking it as draft for now.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft March 23, 2024 15:21
@kmr-srbh
Copy link
Contributor Author

@Shaikh-Ubaid shall I close it?

@Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid shall I close it?

Sure, I think it is safe to close. We can reopen later if needed.

@kmr-srbh kmr-srbh closed this Mar 23, 2024
@kmr-srbh kmr-srbh deleted the fix-asr-output branch March 23, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Severe Bug: Output of --show-asr differs from actual ASR constructed after transformation
2 participants