Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symbolic pass for printing ListItem #2620

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Fix symbolic pass for printing ListItem #2620

merged 7 commits into from
Mar 23, 2024

Conversation

kmr-srbh
Copy link
Contributor

fixes #2613

from lpython import i32

A: list[i32] = [1, 2, 4, 5]
print(A[0], A[1], A[2], "...", A[-3], A[-2], A[-1])
(base) saurabh-kumar@Awadh:~/Projects/System/lpython$ ./src/bin/lpython ./examples/example.py
1 2 4 ... 2 4 5

@kmr-srbh kmr-srbh mentioned this pull request Mar 23, 2024
Closed
Shaikh-Ubaid
Shaikh-Ubaid reviewed Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an integration test for this with print and assert statements.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft March 23, 2024 13:06
@kmr-srbh kmr-srbh marked this pull request as ready for review March 23, 2024 15:24
@kmr-srbh kmr-srbh requested a review from Shaikh-Ubaid March 23, 2024 15:24
Shaikh-Ubaid
Shaikh-Ubaid reviewed Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I shared few comments. It looks good overall.

src/libasr/pass/replace_symbolic.cpp Outdated Show resolved Hide resolved
integration_tests/test_list_item_mixed_print.py Outdated Show resolved Hide resolved
integration_tests/test_list_item_mixed_print.py Show resolved Hide resolved
@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft March 23, 2024 15:32
kmr-srbh and others added 2 commits March 23, 2024 21:10
@kmr-srbh @Shaikh-Ubaid
Remove trailing whitespace
c23b1c8 
Co-authored-by: Shaikh Ubaid <[email protected]>
@kmr-srbh @Shaikh-Ubaid
Simplify statement
4baad5e 
Co-authored-by: Shaikh Ubaid <[email protected]>
@kmr-srbh kmr-srbh marked this pull request as ready for review March 23, 2024 16:03
@kmr-srbh kmr-srbh requested a review from Shaikh-Ubaid March 23, 2024 16:03
Shaikh-Ubaid
Shaikh-Ubaid approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Thanks! Great work!

@Shaikh-Ubaid Shaikh-Ubaid merged commit 4dbbf93 into lcompilers:main Mar 23, 2024
13 checks passed
@kmr-srbh kmr-srbh deleted the fix-list-item-symbolic-pass branch March 26, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaikh-Ubaid Shaikh-Ubaid Shaikh-Ubaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative indices in list fails
2 participants
@kmr-srbh @Shaikh-Ubaid