-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
490 $3 producing Invalid bflc:AppliesTo output #246
Comments
Thanks, Richard. Very helpful. This has been fixed in the new branch for 2.8 development. You can see the tests are passing and the only changes I made were the result of your records: https://github.com/lcnetdev/marc2bibframe2/commits/v2.8-dev/ Incidentally, I moved the 'appliesTo' resource from out of the Series resource to the Relation resource, which is more appropriate. Let me know if you'd rather me create a .1 release of 2.7 or if you just want to move on to this version of the code. About this odd phrasing: "the only changes I made were the result of your records." I noticed no ProvisionActivity resources were coming from the 264s (and corresponding 880s) in your sample records. I fixed that too. The code that deals with 008 provision information and 26X fields employs some mad XSLT so keep an eye on the output for PAs. I don't think I broke anything (and there was decent test coverage for PAs already and those are all passing). |
Thanks for this Kevin. The option of a 2.7.1 is appealing however the site I am working with is a way behind in its version (2.0.2). Is the fix isolated enough to make a backport patch to 2.0.2 feasible? ~Richard |
Following spec documentation, the following:
should result in:
But instead the following is output:
Identified in release version 2.0.2 but quick check shows issue also in version 2.7
3 example marcxml files demonstrating the issue, zipped and attached.
3examples.zip
The text was updated successfully, but these errors were encountered: