Allow users to set PHP memory limit #1316
michaellehmkuhl
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Description:
Commands like
valet use
andvalet install
cause/*/local/etc/php/*/conf.d/php-memory-limits.ini
to be overwritten, even if it already exists. Since this config file is loaded afterphp.ini
, the directives override what users may have set in theirphp.ini
files. In particular, this is a problem when running an application that requires a large amount of memory (e.g., Magento), and can especially be an issue in a CLI environment, where longer running commands might be run.As a workaround, I've taken to creating a file like
/*/local/etc/php/*/conf.d/zzz-final-config.ini
to ensure I can overwrite config settings as needed. This works for now, but it would be better if Valet didn't unexpectedly overwrite config settings that I've changed manually. At the very least, it would be good to see a warning if Valet is changing config files underneath me.Additionally, it would be nice to have a way to configure separate settings for CLI and FPM. I realize this part may be more on the package managers for the Homebrew PHP packages, though.
Steps To Reproduce:
/*/local/etc/php/*/conf.d/php-memory-limits.ini
files.valet install
orvalet use
.php-memory-limits.ini
file is back to the default contents.Diagnosis
N/A
Beta Was this translation helpful? Give feedback.
All reactions