Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial changes #56

Merged
merged 23 commits into from
Sep 28, 2024
Merged

Editorial changes #56

merged 23 commits into from
Sep 28, 2024

Conversation

ounsworth
Copy link
Contributor

No description provided.

ounsworth and others added 15 commits August 5, 2024 19:34
@ounsworth
Private key requires public key. Closes #50
2cbe4bb
@ounsworth
Private key requires public key. Closes #50
a31873d
@ounsworth
Private key requires public key only for traditional component. Thank…
1907c2d 
…s Bas. Closes #50
@ounsworth
Clarify the SHA3 OIDs to use for the CMS section. Closes #43
78fc9c7
@ounsworth
Update Acknowledgements. Closes #44
d9c7b86
@ounsworth
Specified that the tradCT and tradPK inputs to the KEM combiner must …
055b1c5 
…be the raw values without the OCTET STRING wrapper. Closes #49
@ounsworth
TODO: Update this once the on-list discussion settles.
6347be9
@ounsworth
Added a security consideration about key reuse. Closes #38
10d82c0
@ounsworth
Added a security consideration about key reuse. Closes #38
c95fce1
@ounsworth
Added security considerations about SHA3-vs-HKDF-SHA2 and a warning a…
24c009c 
…gainst generifying this construction to other combinations of ciphers. Relates to #42
@ounsworth
Added security considerations about SHA3-vs-HKDF-SHA2 and a warning a…
09f68c0 
…gainst generifying this construction to other combinations of ciphers. Relates to #42
@ounsworth
Tweaks and spell check
4ff648e
@ounsworth
Added reference to GHP18. Relates to #42
d3214ba
@ounsworth
Added statement on ML-KEM applicability
fadc341
@ounsworth
Editorial comments from Piotr. Closes #46
e1202d8
@ounsworth
Copy link
Contributor Author

The security considerations need more work, especially the one about key reuse.

Another argument against key reuse is documented in lamps-wg/draft-composite-sigs#49

janklaussner
janklaussner requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@janklaussner janklaussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small issues, one question

@ounsworth
Copy link
Contributor Author

Closes #72

ounsworth
ounsworth commented Sep 28, 2024
View reviewed changes
@ounsworth
Copy link
Contributor Author

This PR has not been fully reviewed by the author's group, but I have been over it several times and I am merging it to close off all the related Issues.

@ounsworth ounsworth merged commit b9c8f48 into main Sep 28, 2024
2 checks passed
@ounsworth ounsworth deleted the mikeo_editorial branch September 28, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janklaussner janklaussner janklaussner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ounsworth @janklaussner