Broader PDO fetch-style range #59

michalbundyra · 2020-01-16T19:21:31Z

I encountered a situation Where I want to fetch multiple columns with the same name where aliases are not an option, so I set the fetchmode to \PDO::FETCH_NAMED which resulted in the Exception\InvalidArgumentException "The fetch mode must be one of the PDO::FETCH_* constants.", which \PDO::FETCH_NAMED is.

I've attempted to fix this by editing the condition so that all the fetch styles listed in http://php.net/manual/en/pdostatement.fetch.php

I hope that this PR is to the required standards :D

Originally posted by @chris-kruining at zendframework/zend-db#296

The text was updated successfully, but these errors were encountered:

michalbundyra · 2020-01-16T19:21:34Z

@chris-kruining thanks for this PR, I'm sorry to review it only now. The goal of your PR is fine (@Ocramius as library, we need to support all the PDO fetch modes), but I think it's better to check for valid PDO::FETCH_* constants using an array of allowed modes.
Something like this:

use PDO;

class Result implements Iterator, ResultInterface
{
  // ...
  private $allowedFetchModes = [
    PDO::FETCH_ASSOC,
    PDO::FETCH_BOTH,
    PDO::FETCH_BOUND,
    PDO::FETCH_CLASS,
    PDO::FETCH_CLASSTYPE,
    PDO::FETCH_PROPS_LATE,
    PDO::FETCH_INTO,
    PDO::FETCH_LAZY,
    PDO::FETCH_NAMED,
    PDO::FETCH_NUM,
    PDO::FETCH_OBJ
  ];

  /**
   * @param int $fetchMode
   * @throws Exception\InvalidArgumentException on invalid fetch mode
   */
  public function setFetchMode($fetchMode)
  {
      if (! in_array($fetchMode, $this->allowedFetchModes)) {
          throw new Exception\InvalidArgumentException(
              'The fetch mode must be one of the PDO::FETCH_* constants.'
           );
      }
      $this->fetchMode = (int) $fetchMode;
  }
}

This change is required also for fix an issue on the previous implementation. In fact, checking for $fetchMode < 1 || $fetchMode > 10 is not enough. For instance 7 is not a valid PDO::FETCH_* mode.

@chris-kruining can you change this PR according to my suggestion? Thanks a ton!

Originally posted by @ezimuel at zendframework/zend-db#296 (comment)

michalbundyra · 2020-01-16T19:21:36Z

@ezimuel I've made the changed like you proposed, however I do have some concerns:

In my opinion is not a completely valid set as \PDO::FETCH_PROPS_LATE and \PDO::FETCH_CLASSTYPE should only be used in combination with \PDO::FETCH_CLASS

Originally posted by @chris-kruining at zendframework/zend-db#296 (comment)