Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@lowest and @latest is not respected when project provides explicit checks #84

Closed
boesing opened this issue Mar 30, 2022 · 1 comment · Fixed by #83
Closed

@lowest and @latest is not respected when project provides explicit checks #84

boesing opened this issue Mar 30, 2022 · 1 comment · Fixed by #83
Labels
Bug Something isn't working
Milestone

Comments

@boesing
Copy link
Member

boesing commented Mar 30, 2022

Bug Report

Q A
Version(s) 1.11.4

Summary

I am currently working on providing integration tests in #62
There, I've seen that @lowest and @latest is not properly handled by the matrix action when it comes to explicit checks provided by the projects .laminas-ci.json

Current behavior

When @lowest and/or @latest is used for job.php, the action does skip that job:

::warning::Invalid job provided; no PHP version or unknown PHP version specified: {"php":"@lowest","dependencies":"locked","command":"vendor/bin/phpunit"}
::warning::Invalid job provided; no PHP version or unknown PHP version specified: {"php":"@latest","dependencies":"locked","command":"vendor/bin/phpunit"}

How to reproduce

.laminas-ci.json
{
    "checks": [
        {
            "name": "PHPUnit with locked dependencies on lowest supported PHP version",
            "job": {
                "php": "@lowest",
                "dependencies": "locked",
                "command": "vendor/bin/phpunit"
            }
        },
        {
            "name": "PHPUnit with locked dependencies on lowest supported PHP version",
            "job": {
                "php": "@latest",
                "dependencies": "locked",
                "command": "vendor/bin/phpunit"
            }
        }
    ]
}

Expected behavior

Matrix does not report a warning for @lowest or @latest and properly uses the lowest and latest supported PHP version by the project within the job declaration.

@boesing boesing added the Bug Something isn't working label Mar 30, 2022
@boesing boesing linked a pull request Jun 30, 2022 that will close this issue
7 tasks
@boesing
Copy link
Member Author

boesing commented Jun 30, 2022

Will be fixed with #83

@boesing boesing added this to the 1.12.0 milestone Jun 30, 2022
@boesing boesing mentioned this issue Jun 30, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant