You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The .laminas-ci.json allows to pass checks which overrides the additional_checks and thus are mutually exclusive. This makes the JSON schema more bloated as we have to provide two configuration combinations with either checks or additional_checks.
The .checks[].job element has is allowed to be a string which also makes it more error-prone.
It also states that it is possible to select an additional "action" which can be used with the CI matrix which is actually not really true as if someone choses another "action", that action also have to parse the job JSON-string and from this perspective, I dont really see the benefit of having checks.
Due to the fact that .checks[].job is a string, it also cannot be validated by the JSON schema which is feature-requested in #49.
Is there any project around which uses the .checks functionality from .laminas-ci.json? If not, I would prefer getting rid of that to simplify the matrix action.
The text was updated successfully, but these errors were encountered:
Feature Request
Summary
The
.laminas-ci.json
allows to passchecks
which overrides theadditional_checks
and thus are mutually exclusive. This makes the JSON schema more bloated as we have to provide two configuration combinations with eitherchecks
oradditional_checks
.The
.checks[].job
element has is allowed to be a string which also makes it more error-prone.It also states that it is possible to select an additional "action" which can be used with the CI matrix which is actually not really true as if someone choses another "action", that action also have to parse the
job
JSON-string and from this perspective, I dont really see the benefit of havingchecks
.Due to the fact that
.checks[].job
is a string, it also cannot be validated by the JSON schema which is feature-requested in #49.Is there any project around which uses the
.checks
functionality from.laminas-ci.json
? If not, I would prefer getting rid of that to simplify the matrix action.The text was updated successfully, but these errors were encountered: