Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks being ignored because we transition the slot a couple of milliseconds later compared to peers (Sepolia long run) #1315

Closed
rodrigo-o opened this issue Oct 2, 2024 · 1 comment · Fixed by #1316
Closed

Blocks being ignored because we transition the slot a couple of milliseconds later compared to peers (Sepolia long run) #1315

rodrigo-o opened this issue Oct 2, 2024 · 1 comment · Fixed by #1316
Assignees
@rodrigo-o
Labels
bug Something isn't working P1 This is a MUST for this milestone. It's a main feature, or blocking other main features.

Comments

@rodrigo-o
Copy link
Collaborator

This issue was spot on muntiple test, and was close in time to the ocurrence of #1309. After solving it in a test branch, the issue doesn't impacted on #1309 issue, but it's still a bug so this issue is created to track it and solve it. The problem is apparently related to the MAXIMUM_GOSSIP_CLOCK_DISPARITY not being taken into account. It's a P1 because it appears to be the cause of other issues, but i wasn't able to pinpoint them yet, given that the solution is pretty straightforward I preferred to tackle it now.
@rodrigo-o rodrigo-o added bug Something isn't working P1 This is a MUST for this milestone. It's a main feature, or blocking other main features. labels Oct 2, 2024
@rodrigo-o rodrigo-o self-assigned this Oct 2, 2024
@rodrigo-o rodrigo-o changed the title Blocks being ignored because we transition the slot a couple of milliseconds later Blocks being ignored because we transition the slot a couple of milliseconds later compared to peers Oct 2, 2024
@rodrigo-o rodrigo-o changed the title Blocks being ignored because we transition the slot a couple of milliseconds later compared to peers Blocks being ignored because we transition the slot a couple of milliseconds later compared to peers (Sepolia long run) Oct 2, 2024
@rodrigo-o
Copy link
Collaborator Author

As far as i understando this won't happen on mainnet (because block proposing is not done immediately at the beginning of the slot) but it clearly affects our testnet runs.

@rodrigo-o rodrigo-o mentioned this issue Oct 2, 2024
Merged
@rodrigo-o rodrigo-o mentioned this issue Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigo-o rodrigo-o

Labels
bug Something isn't working P1 This is a MUST for this milestone. It's a main feature, or blocking other main features.
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
1 participant
@rodrigo-o