Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert_eq!() usage for actual errors in frame.rs #1748

Open
ElFantasma opened this issue Jan 20, 2025 · 0 comments
Open

Replace assert_eq!() usage for actual errors in frame.rs #1748

ElFantasma opened this issue Jan 20, 2025 · 0 comments
Labels
L1 network Issues related to network communication tech debt Refactors, cleanups, etc

Comments

@ElFantasma
Copy link
Contributor

There are some checks in the decode() function for RLPxCodec that currently are handled with assert_eq!() macro.

While this is useful, (we still find some discrepancies from time to time and want to log them in console) we should handle them with proper error messages instead.
@ElFantasma ElFantasma added network Issues related to network communication tech debt Refactors, cleanups, etc L1 labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L1 network Issues related to network communication tech debt Refactors, cleanups, etc
Projects
ethrex_l1
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ElFantasma