Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(l1): wrong logic when validating peer ForkID #1685

Open
fmoletta opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1729
Open

bug(l1): wrong logic when validating peer ForkID #1685

fmoletta opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1729
Assignees
Labels
bug Something isn't working L1 network Issues related to network communication

Comments

@fmoletta
Copy link
Contributor

When we connect to a peer and exchange Status messages we validate their ForkID, the fork id is derived from the genesis, chain config, and block number and timestamp of the latest block. When we connect to a peer with the purpose of syncing our fork ids will not match, as our peer should be on a further block. Therefore we shouldn't check that our fork ids are the exact same but instead check for compatibility as described in: https://eips.ethereum.org/EIPS/eip-2124

@fmoletta fmoletta added bug Something isn't working network Issues related to network communication L1 labels Jan 10, 2025
@mpaulucci mpaulucci added this to the [L1] 4 - P2P Network milestone Jan 10, 2025
@avilagaston9 avilagaston9 self-assigned this Jan 10, 2025
@avilagaston9 avilagaston9 linked a pull request Jan 16, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working L1 network Issues related to network communication
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants