Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEVM: Refactor the main method flow #1633

Closed
4 tasks
ilitteri opened this issue Jan 6, 2025 · 3 comments
Closed
4 tasks

LEVM: Refactor the main method flow #1633

ilitteri opened this issue Jan 6, 2025 · 3 comments
Assignees
Labels
levm Lambda EVM implementation refactor

Comments

@ilitteri
Copy link
Contributor

ilitteri commented Jan 6, 2025

  • The new transact method should: prepare the VM for execution -> execute -> resolve the execution result -> perform the post-execution logic -> return the transaction execution report.
  • execute should return an ExecutionResult.
  • There should be a resolve_execution_result function that takes the ExecutionResult and returns the TransactionExecutionReport.
  • The TransactionExecutionReport should be altered by the post-execution logic as needed.
@lima-limon-inc
Copy link
Contributor

On it! See: #1807

@lima-limon-inc
Copy link
Contributor

The new transact method should: prepare the VM for execution -> execute -> resolve the execution result -> perform the post-execution logic -> return the transaction execution report.

I think this is basically the case now. There is an if statement I'd like to remove (see here), although it has proven to be harder than expected. I'll tackle it later on.

@lima-limon-inc
Copy link
Contributor

I'm marking the Issue as closed. The main ideas got implemented in different PR's.

See this comment for more information: #1807 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
levm Lambda EVM implementation refactor
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants