Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units in spinbox for analog quantities #12

Open
philipstarkey opened this issue Jun 22, 2017 · 2 comments
Open

Units in spinbox for analog quantities #12

philipstarkey opened this issue Jun 22, 2017 · 2 comments
Labels
enhancement New feature or request minor

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).


As per @Spielman's suggestion in pull request #12, we should consider moving the units to within the spinbox for analog quantity widgets.

I would encourage a solution where the Hz (for exampe) is rendered in the spinbox and perhaps where a right click gives access to the units.

The unit change could be a sub-menu in the right-click menu for that widget. This helps to avoid the "jagged" appearance of the new vertical DDS widget layout.

@philipstarkey
Copy link
Member Author

Original comment by Ian B. Spielman (Bitbucket: Ian Spielman, GitHub: ispielma).


I would make it the only content of the right click menu.

@philipstarkey
Copy link
Member Author

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


I don't think it's feasible to have only the units in the right click menu. The right click menu is already populated with BLACS specific features such as changing the default step size for the widget and locking the control against accidental changes. We might be able to make it so that a left click on the units text (the suffix of the QDoubleSpinBox) brings up a separate context menu that just contains units.

Alternatively (and actually I think I might prefer this one) we could have a (small) button next to the spin box, like we do next to the repeat button in the queue, that brings up a menu of units. That would probably be a lot easier to implement as well.

@philipstarkey philipstarkey added minor enhancement New feature or request labels Apr 5, 2020
Loki27182 pushed a commit to Loki27182/labscript-utils that referenced this issue Oct 9, 2023
…-suite#12)

More compact DDS widgets

Approved-by: Shaun Johnstone <[email protected]>
Approved-by: Philip Starkey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

1 participant