-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error running module on Linux #53
Comments
That is because zip files don't contain filesystem permissions, you should set the permissions for the executables manually, unfortunately. Related to actions/upload-artifact#38 . |
A solution would be to generate a |
That is not really acceptable. At least when you make the official release on github please upload a .tar.gz. |
Yes, I understand and agree that this is unacceptable behaviour. In the issue referred, people are mad about this not begin yet fixed, unfortunately. Meanwhile, releases are manual so, manually checking it is mandatory to make sure everything doesn't break. Although, I would suggest keeping this issue open until the dependent action fixes it on their side. |
@miguel-negrao a new release was manually created https://github.com/labcif/GBoard4A/releases/tag/1.0.0 . The artifacts have now a |
Tested the release, runs fine here. Congratulations on the release. :-) |
Perhaps https://github.com/softprops/action-gh-release can be used. |
That is to publish releases automatically. The action I'm using is only to generate release artefacts instead of publishing. The idea would be to have a staging step before release to manually test if the artifact is well generated and good for release. This is a good practice because tags on git should be immutable and if a tag generates malformed artefacts, then a malformed release will be pushed, which is not good.
For this to happen flawlessly, it would be good to already have the generated artefacts with proper permissions, although, there is nothing preventing us to generate a Some CIs have manual approval to CI steps. Circle CI, for example, already has a feature to manually do this https://circleci.com/docs/2.0/triggers/#manual-approval . For Github workflows, there is a way to do manual approvals, see here: https://devblogs.microsoft.com/devops/i-need-manual-approvers-for-github-actions-and-i-got-them-now/ Although, I don't have permission to add that right now. |
Let me know if you want me to add manual approvals, detailing exactly what I need to do. |
It appears
gboard-forensics
is doesn't have execute permission. This is for version posted privately on Teams.After manually setting the execute permission the module runs fine.
The text was updated successfully, but these errors were encountered: