-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chord display should understand no 5th chords #18
Comments
Hello @sreich, thanks for the feedback. i did not have time to work on MIDI JAR recently, I’m busy with something else. But fixing some incoherence with the tonaljs library is in my top priority, as I noticed this kind of issues too (like missing chords, incoherent notations, and such). |
Okay! No problem, life happens. Glad you're getting to it and planning for it... Thank you for the fast response and explanation. Take your time. By the time you get to it I'll just be that much better at piano practice to use your app 😉 |
Hello @sreich ! I just finalized the latest release of MIDI Jar 1.5.0, which is a complete rewrite of the chord dictionary used by tonal. I did not implement the mention of the "no5" and such in chord display, since there already are a lot of information displayed on screen. You can enable the "Allow omissions" option in the chord-display settings, and it should be all good. Planning to add a gameplay option to allow omissions / alterations in Chord Quiz, but i would also like to have an option to require a specific inversion (at least a bass note). Hope you will appreciate this release, don't hesitate to give feedback if you have any issue with this ticket, otherwise, i'll close it. |
Hey, this sound awesome! Sounds like really great improvements, thank you. I've also been enjoying the interface improvements you've been making I opened #22 because I'm unable to get 1.5.0 |
It seems that midi jarr gets confused when you drop the 5th from extended chords
Take an Emaj7 for instance, root position. E, G#, B and D#...
You can see it understand this chord. However, if you remove the 5th(leave out the B) as jazz often does... It gets confused and won't show it as any chord...
But, to my eyes I can see this and understand it's just an Emaj7 without a 5th. What's weird is I've seen it before say "no5" for a chord... So it does kinda understand this concept in some contexts...
The text was updated successfully, but these errors were encountered: