feat(kvstore API): Implement /api/get with HTTP GET #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed implementation, started redocumenting and testing
levaitamas
changed the title
levaitamas
changed the title
levaitamas
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Thanks for working on this, @benjoe1126! It looks good to me sofar. Can you check and update the tests (e.g., 99-labs/code/kvstore/pkg/client/client_test.go) too?
|
The tests seem fine and once the client is implemented according to the new definitions it runs as expected |
My bad, that was correct indeed. |
|
One minor (and perhaps the final) nit: can you update the 99-labs/05-resilience/README too? Thanks! |
Sure thing, will do so soon :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now the /api/get endpoint uses HTTP get method and query parameters