Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make finalizer less restrictive #286

Closed
Tracked by #275
Teneroy opened this issue Nov 27, 2024 · 0 comments · Fixed by #298
Closed
Tracked by #275

Make finalizer less restrictive #286

Teneroy opened this issue Nov 27, 2024 · 0 comments · Fixed by #298
Assignees

Comments

@Teneroy
Copy link
Collaborator

Teneroy commented Nov 27, 2024

Right now finalizer prevents us from getting any answer in many cases when it could. We need to make it less restrictive, including when it gives us multiple variations of an answer.
The integration tests are flaky and repeatedly fail, blocking PRs from being merged.
You do not need to improve or add on to the problematic test cases.

To Do

  • Investigate which test cases are flaky causing the integration test to fail
  • Improve the finalizer prompt(probably by decreasing restrictiveness) to make test cases pass reliably

Example of the problem:
Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants