Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RateLimit feature toggle removal #1608

Open
15 tasks
Tracked by #1365
strekm opened this issue Jan 15, 2025 · 0 comments
Open
15 tasks
Tracked by #1365

RateLimit feature toggle removal #1608

strekm opened this issue Jan 15, 2025 · 0 comments
Assignees
@joanbod
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Milestone
2.11.0

Comments

@strekm
Copy link
Contributor

strekm commented Jan 15, 2025 •
edited
Loading

Description

Remove feature toggle guarding rate limiting feature.

ToDos [Developer]

  • remove build task
  • remove ratelimit_disabled file
  • adjust make / docker file if need
  • remove ratelimit const
  • remove ratelimit const from tests

PRs

ACs [PO]

  • rate limit functionality exposed
  • release notes prepared

DoD [Developer & Reviewer]

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • If the default configuration of Istio Operator has been changed, you performed a manual upgrade test to verify that the change can be rolled out correctly.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments
@strekm strekm added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 15, 2025
@strekm strekm added this to the 2.11.0 milestone Jan 15, 2025
@strekm strekm mentioned this issue Jan 15, 2025
Open
16 tasks
@strekm strekm added the area/api-gateway Issues or PRs related to api-gateway label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanbod joanbod

Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.11.0
Development

No branches or pull requests
2 participants
@strekm @joanbod