Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): update slack community link #8648

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

lplazas
Copy link
Contributor

@lplazas lplazas commented Dec 17, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
    Not creating to avoid extra toil
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

None of the above needed as it is just a documentation change

@lplazas lplazas requested a review from a team as a code owner December 17, 2023 21:39
@lplazas lplazas requested review from jakubdyszkiewicz and Automaat and removed request for a team December 17, 2023 21:39
@lahabana
Copy link
Contributor

Thx a lot!

@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Dec 18, 2023
@lahabana lahabana changed the title fix(docs):Update slack community link docs(README):Update slack community link Dec 18, 2023
@lahabana lahabana enabled auto-merge (squash) December 18, 2023 08:24
@@ -10,7 +10,7 @@ contributors and maintainers.

[Slack](https://kuma-mesh.slack.com) is the main chat channel used by the
community and the maintainers of this project. If you do not have an
existing account, please follow this [link](https://join.slack.com/t/kuma-mesh/shared_invite/zt-1rcll3y6t-DkV_CAItZUoy0IvCwQ~jlQ) to sign
existing account, please follow this [link](https://join.slack.com/t/kuma-mesh/shared_invite/zt-1tu98qcw4-pJNW9lRdBqx1I9kF9rvImA) to sign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why the old one expired (I did not do anything with my account, do they expire base on time?). @lahabana - should we bring back the invite bot somehow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this link was present in multiple places so need to update all of them 😢

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now that I re-generated the link it said that it expires in 30 days. I'm 99% sure that was not the case last time I generated it.

image

We probably don't want to repeat this every month so probably need to invest in something like https://communityinviter.com/ ?

@slonka slonka changed the title docs(README):Update slack community link docs(readme): update slack community link Dec 18, 2023
@lahabana lahabana merged commit fb331af into kumahq:master Jan 2, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants