-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bootstrap): support customizing corefile template from kuma-cp #8634
Merged
jijiechen
merged 7 commits into
kumahq:master
from
jijiechen:configurable-corefile-template
Jan 2, 2024
Merged
feat(bootstrap): support customizing corefile template from kuma-cp #8634
jijiechen
merged 7 commits into
kumahq:master
from
jijiechen:configurable-corefile-template
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for the label :) |
484af61
to
0699546
Compare
slonka
reviewed
Dec 18, 2023
jakubdyszkiewicz
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contrib!
Can you also add this new setting to pkg/config/app/kuma-cp/kuma-cp.defaults.yaml
?
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
…dns startup Signed-off-by: Jay Chen <[email protected]>
4c8ce69
to
670b91a
Compare
…om cp to dp Signed-off-by: Jay Chen <[email protected]>
19b2a31
to
84070af
Compare
I'm still working on passing the E2E tests |
70e7b3f
to
84070af
Compare
…e customization Signed-off-by: Jay Chen <[email protected]>
The E2E tests are passing. |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OSci/
labels to run additional/fewer testsUPGRADE.md
?