Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bootstrap): support customizing corefile template from kuma-cp #8634

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

jijiechen
Copy link
Member

@jijiechen jijiechen commented Dec 15, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • Should not block as it's adding a new feature.
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Added
    • Don't forget ci/ labels to run additional/fewer tests
      • Should run normally
  • Do you need to update UPGRADE.md?
    • No, it's compatible with old versions
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • No backport needed

@lahabana
Copy link
Contributor

No need for the label :)

@jijiechen jijiechen force-pushed the configurable-corefile-template branch from 484af61 to 0699546 Compare December 18, 2023 07:55
app/kuma-dp/cmd/run_test.go Outdated Show resolved Hide resolved
@jijiechen jijiechen marked this pull request as ready for review December 19, 2023 02:23
@jijiechen jijiechen requested a review from a team as a code owner December 19, 2023 02:23
@jijiechen jijiechen requested review from slonka and jakubdyszkiewicz and removed request for a team December 19, 2023 02:23
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contrib!

Can you also add this new setting to pkg/config/app/kuma-cp/kuma-cp.defaults.yaml ?

app/kuma-dp/cmd/run.go Outdated Show resolved Hide resolved
@jijiechen jijiechen force-pushed the configurable-corefile-template branch from 4c8ce69 to 670b91a Compare December 22, 2023 02:39
@jijiechen jijiechen force-pushed the configurable-corefile-template branch from 19b2a31 to 84070af Compare December 22, 2023 08:54
@jijiechen
Copy link
Member Author

I'm still working on passing the E2E tests

@jijiechen jijiechen force-pushed the configurable-corefile-template branch from 70e7b3f to 84070af Compare December 22, 2023 16:13
@jijiechen
Copy link
Member Author

The E2E tests are passing.

@jijiechen jijiechen merged commit d0eaac3 into kumahq:master Jan 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants