feat(kuma-cp): move protocol information to mesh context

[lukidzi]

Checklist prior to review

We called the method InferProtocol in some plugins with Endpoints already filtered by old policies. That caused some of the services not to be available. In this change, I am creating a Map with service information about protocol based on EndpointMap. This allows us to make the calculation once in a mesh context and share it between plugins. Also, we don't need proxy.Routing which we want to avoid using in new policies.

• Link to relevant issue as well as docs and UI issues
  • Closes: Refactor InferProtocol  #8468
• This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
• Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Don't forget ci/ labels to run additional/fewer tests
• Do you need to update UPGRADE.md? --
• Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

[lahabana]

i don't see any of the backcompat code here. What happens when we upgrade and serviceInsight is not populated? Also what happens when a new service is created and it's not in serviceInsight yet? I'd expect we need to artificially backfill for at least back compat no?

[lahabana]

Jakub pointed that service insights are copied from Global to Zone. We should check and understand this.

[lukidzi]

Jakub pointed that service insights are copied from Global to Zone. We should check and understand this.

Yes, it seems like ServiceInsights calculations are running on Global/Standalone but not Zone. So if there is no connection we might have old data. The code of resyncer is responsible for serviceInsight generation.

We have some options:

• relay on ServiceInsight - problem when Global is down
• enable ServiceInsight on zone - we would need to sync to global/create global serviceInsight?
• use EndpointMap - instead of calling for each policy we can just build this in mesh context once per each service and provide protocol in ServiceInsight only for UI purpose?

[lahabana]

I think you are right we're trying to do too much at once. Let's remove the deps of plugins on proxy.Routing we can later look not use all the dataplanes to figure the protocol of a service.

[bartsmykla]

Some nits

[lahabana]

LGTM! Sorry I wanted to sit down to properly look at this change