Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): run amd64 E2E on GitHub actions and arm64 on CircleCI #8476

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

jijiechen
Copy link
Member

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • N/A
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • Confirmed
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Manually tested
    • Don't forget ci/ labels to run additional/fewer tests
      • Added
  • Do you need to update UPGRADE.md?
    • No need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • No need to back-port.

This PR follows the previous one at here and supports running E2E tests on GitHub Actions when arch is amd64, other arches will still run on CircleCI

@jijiechen jijiechen added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) no-backport-autolabel labels Nov 28, 2023
@jijiechen jijiechen requested a review from a team as a code owner November 28, 2023 09:41
@jijiechen jijiechen requested review from lobkovilya and lukidzi and removed request for a team November 28, 2023 09:41
@jijiechen
Copy link
Member Author

jijiechen commented Nov 28, 2023

Example runs:

  1. a normal run with priority cases only: https://github.com/jijiechen/kuma/actions/runs/7015203805
  2. a full matrix run: https://github.com/jijiechen/kuma/actions/runs/7029516082 (fail because of code errors)

This PR look large because it contains all the changes in the previous PR. I'll update this PR as soon as the previous one is merged so that it'll be cleaner.

@jijiechen jijiechen force-pushed the gh-actions-e2e-run-pr branch from eb38821 to e1fdd97 Compare November 28, 2023 10:20
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
@jijiechen jijiechen force-pushed the gh-actions-e2e-run-pr branch from e1fdd97 to 63f7fac Compare November 29, 2023 07:46
@jijiechen jijiechen merged commit f45667d into kumahq:master Nov 29, 2023
11 checks passed
@jijiechen jijiechen deleted the gh-actions-e2e-run-pr branch December 7, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) no-backport-autolabel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants