-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(actions): trigger E2E tests on CircleCI manually from GitHub Actions #8426
Conversation
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
--header "x-attribution-login: ${{ github.actor }}" \ | ||
--header "x-attribution-actor-id: ${{ github.actor }}" \ | ||
--header "Circle-Token: ${{ inputs.secureCircleCIToken }}" \ | ||
--data "$BODY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we don't use: https://github.com/CircleCI-Public/trigger-circleci-pipeline-action is that we can't pass params? I guess the problem with this is that we don't block until completion no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of having parameters to the circleci job we should just read https://github.com/CircleCI-Public/trigger-circleci-pipeline-action/tree/main#gha_meta in the circleCI job ?s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we can't pass custom parameters using that action. That's why I call it manually. The GHA_Meta
provides a way to pass custom parameters, we have to composite all params into one in this way, and we don't have a easy way to extract these params as part of the CircleCI workflow (using their setup
job could be a way, that might require significant changes to the whole strcture).
In terms of blocking until completion, I believe that action does not provide this ability either. I read through the source code, and checkout of their readme, they are calling the same API with the one in my code and they only provide state of the just-created pipeline as an output as well.
For blocking until complete, we may laverage their other APIs to all workflows and periodically check latest state. Doc at https://circleci.com/docs/api/v2/index.html#operation/getWorkflowById
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OSci/
labels to run additional/fewer testsUPGRADE.md
?This PR adds the ability to trigger E2E tests on CircilCI manually from GitHub Actions.