Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): generate e2e tests matrix #8424

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

jijiechen
Copy link
Member

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
    • N/A
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • Confirmed
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Mannually tested
    • Don't forget ci/ labels to run additional/fewer tests
      • Added
  • Do you need to update UPGRADE.md?
    • No need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • No need

This PR adds the ability to generate matrix for running E2E tests on GitHub Actions.

No E2E tests will be run at this time.

@jijiechen jijiechen added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) no-backport-autolabel labels Nov 21, 2023
@jijiechen jijiechen self-assigned this Nov 21, 2023
@jijiechen jijiechen requested a review from a team as a code owner November 21, 2023 03:27
@jijiechen jijiechen requested review from slonka, jakubdyszkiewicz, lahabana and a team and removed request for a team November 21, 2023 03:27
@jijiechen
Copy link
Member Author

An example can be found here: https://github.com/jijiechen/kuma/actions/runs/6938484757
The ci/skip-* and ci/run-full-matrix labels are also supported.

.github/workflows/build-test-distribute.yaml Outdated Show resolved Hide resolved
.github/workflows/build-test-distribute.yaml Outdated Show resolved Hide resolved
.github/workflows/build-test-distribute.yaml Outdated Show resolved Hide resolved
.github/workflows/build-test-distribute.yaml Outdated Show resolved Hide resolved
.github/workflows/build-test-distribute.yaml Outdated Show resolved Hide resolved
.github/workflows/build-test-distribute.yaml Outdated Show resolved Hide resolved
@jijiechen jijiechen force-pushed the gh-actions-e2e-matrix-gen branch from c40f055 to 9a52847 Compare November 22, 2023 13:56
@jijiechen
Copy link
Member Author

I've just updated code with the first approach of merging matrix generating.
Please have a look at your convenience. @lahabana

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM This looks great and good to go I think! Do you have an example run of this?

@jijiechen
Copy link
Member Author

Yes, here are two:

In these examples, I took out dependencies from e2e to build, so the graphic could be slightly different than expected. The matrix generation was working the expected way.

@lahabana lahabana closed this Nov 23, 2023
@lahabana lahabana reopened this Nov 23, 2023
@lahabana lahabana merged commit 705790b into kumahq:master Nov 23, 2023
19 checks passed
@jijiechen jijiechen deleted the gh-actions-e2e-matrix-gen branch November 27, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) no-backport-autolabel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants