Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): add 80/20 split for local only services #8235

Merged
merged 3 commits into from
Nov 20, 2023
Merged

test(e2e): add 80/20 split for local only services #8235

merged 3 commits into from
Nov 20, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Nov 2, 2023 •
edited
Loading

I've noticed a few flakes of the 80/20 test for mutlizone:

This PR adds a similar test for local traffic, so we can observe if the problem relates exclusively to multizone traffic.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lobkovilya lobkovilya marked this pull request as ready for review November 3, 2023 12:19
@lobkovilya lobkovilya requested a review from a team as a code owner November 3, 2023 12:19
@lobkovilya lobkovilya requested review from bartsmykla and lukidzi and removed request for a team November 3, 2023 12:19
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the context this addition in PR description. Was something broken? Did we not cover this? Why are we adding this now

@lobkovilya
Copy link
Contributor Author

Right, I updated the PR description.

@lobkovilya lobkovilya merged commit 2338386 into kumahq:master Nov 20, 2023
@lobkovilya lobkovilya deleted the e2e/80-20-split-local-only branch November 20, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobkovilya @jakubdyszkiewicz