Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(xds): put the Gatewaylisteners in the Proxy #8051

Merged
merged 3 commits into from
Oct 24, 2023
Merged

perf(xds): put the Gatewaylisteners in the Proxy #8051

merged 3 commits into from
Oct 24, 2023

Conversation

lahabana
Copy link
Contributor

We were constantly recomputing these.
This was making code hard to read and proxy had some memory impact.

We also introduce a plugin API for proxy modification which helps avoiding circular dependency between core_xds and plugins

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested a review from a team as a code owner October 16, 2023 15:17
@lahabana lahabana requested review from slonka and Automaat and removed request for a team October 16, 2023 15:17
@lahabana
fix(perf): put the Gatewaylisteners in the Proxy
859cf9b 
We were constantly recomputing these.
This was making code hard to read and proxy had some memory impact.

We also introduce a plugin API for proxy modification which helps
avoiding circular dependency between core_xds and plugins

Signed-off-by: Charly Molter <[email protected]>
@lahabana
Copy link
Contributor Author

@Automaat updated thx!

@lahabana lahabana merged commit fb8d58a into kumahq:master Oct 24, 2023
@lahabana lahabana changed the title fix(perf): put the Gatewaylisteners in the Proxy perf(xds): put the Gatewaylisteners in the Proxy Nov 3, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
@lahabana lahabana deleted the matchingFix branch March 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Automaat Automaat Automaat approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @Automaat