Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect with an unknown mesh returns a non helpful error message #7695

Open
lahabana opened this issue Sep 7, 2023 · 8 comments
Open

Inspect with an unknown mesh returns a non helpful error message #7695

lahabana opened this issue Sep 7, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Sep 7, 2023

What happened?

$ ./build/artifacts-darwin-arm64/kumactl/kumactl inspect timeout timeout-all-default -m foo
Error: Could not list Dataplanes (Not found)

It should say the mesh doesn't exist.

It looks like it's there:

meshContext, err := builder.Build(ctx, meshName)
if err != nil {
rest_errors.HandleError(request.Request.Context(), response, err, "Could not list Dataplanes")
return
}

I guess we return a NotFound error from the store. We should do a better job there, probably a dedicated error or something like this.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it good first issue Good for newcomers and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 7, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 11, 2023
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Dec 11, 2023
@lakshya8066
Copy link

HI @lahabana can I work on this?

@lahabana
Copy link
Contributor Author

Of course!

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 16, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Mar 18, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 17, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lobkovilya lobkovilya removed the triage/stale Inactive for some time. It will be triaged again label Jun 17, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Sep 16, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka
Copy link
Contributor

slonka commented Sep 16, 2024

$ ./build/artifacts-darwin-arm64/kumactl/kumactl inspect timeout timeout-all-default -m foo
Error: Could not list Dataplanes (Not found)

still the same

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Sep 16, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 16, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

6 participants