Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targeting MeshHTTPRoute from policies #5867

Closed
lahabana opened this issue Jan 30, 2023 · 4 comments
Closed

Targeting MeshHTTPRoute from policies #5867

lahabana opened this issue Jan 30, 2023 · 4 comments
Assignees
@lobkovilya
Labels
kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

Policies should work with a to on MeshHTTPRoute for example to setup a timeout just for a subset of endpoints
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Jan 30, 2023
@lobkovilya
Copy link
Contributor

Also, it could be implemented differently, for example using MeshHTTPRoute in top-level targetRef:

type: MeshTimeout
spec:
  targetRef:
    kind: MeshHTTPRoute
    name: my-http-route-1
  to: [...]

Basically, we should decide if policies target Route or they target Attachment of the Route to DPP.

If MeshTimeout targets Route then it implicitly targets all DPPs targeted by the Route.
If MeshTimeout targets Attachment of the Route to DPP then we should decide what happens if the route is deleted (warning or maybe protecting referenced routes from deletion).

That's why I think we need MADR for this one.

@jakubdyszkiewicz jakubdyszkiewicz added kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it and removed kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Jan 30, 2023
@michaelbeaumont
Copy link
Contributor

👍 on MADR, IMO this is a fundamentally different type of target

@lahabana
Copy link
Contributor Author

lahabana commented Feb 28, 2023 •
edited
Loading

xref: #3250 (specific to MeshTrafficPermission)

@lahabana lahabana mentioned this issue Apr 21, 2023
Closed
@lobkovilya lobkovilya mentioned this issue May 17, 2023
Merged
6 tasks
@lobkovilya
Copy link
Contributor

lobkovilya commented Jun 5, 2023 •
edited
Loading

#6786 provides an MADR, so closing this issue. Implementation is tracked here #6923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lobkovilya lobkovilya

Labels
kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lahabana @michaelbeaumont @jakubdyszkiewicz @lobkovilya