Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from circleci to github actions #4754

Closed
lahabana opened this issue Aug 3, 2022 · 16 comments
Closed

Move from circleci to github actions #4754

lahabana opened this issue Aug 3, 2022 · 16 comments
Assignees
Labels
area/ci-cd kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Aug 3, 2022

What happened?

github actions is free for OSS so we'd save some money.

In the past there were blockers to do this. The ones I remember of were: parallel runs and arm worker.
We should first check if we have everything to move to github actions and then maybe do it.

Apparently parallel runs is possible with: https://rubyyagi.com/how-to-run-tests-in-parallel-in-github-actions/

@lahabana lahabana added area/ci-cd triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature labels Aug 3, 2022
@slonka
Copy link
Contributor

slonka commented Aug 12, 2022

I found GH actions limits:

image

we use 400 minutes per one run (including parallel runs) so that would only last for 5 runes. If the table above is right we might want to just close this or consider self-hosted runners.

@michaelbeaumont
Copy link
Contributor

We need to compare the price of credits/minutes and check the number of free minutes for CircleCI

@slonka
Copy link
Contributor

slonka commented Aug 16, 2022

It's up to* 6000 build minutes / month
image

* - using small docker resource class which we're probably not using

@aktech
Copy link

aktech commented Aug 16, 2022

Hey @slonka Sorry for jumping on this. "self-hosted" got my attention.

If the table above is right we might want to just close this or consider self-hosted runners.

You can achieve this with https://cirun.io It creates on demand runners for GitHub Actions on your cloud and manages the complete lifecycle. You simply connect your cloud provider and define what runners you need in a simple yaml file and that's it.

See https://docs.cirun.io/reference/examples.html#aws for example. Let me know if you have any questions. I am the creator of Cirun.

@slonka
Copy link
Contributor

slonka commented Aug 18, 2022

Hi @aktech - if you can show that it is significantly more cost efficient then we will consider it.

@aktech
Copy link

aktech commented Aug 18, 2022

Hey @slonka sure I'll share some numbers/demo for the same, also just to clarify Cirun.io is free for Open Source, you only pay to your cloud provider for the VM usage.

@lahabana
Copy link
Contributor Author

Free for org is different from OSS free. AFAIU github actions is 100% free for OSS projects.

@aktech
Copy link

aktech commented Aug 22, 2022

Free for org is different from OSS free. AFAIU github actions is 100% free for OSS projects.

That's absolutely true, my suggestion was for ARM runners, which are only available via self-hosted.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 21, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Nov 21, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 20, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Feb 20, 2023
@lahabana
Copy link
Contributor Author

One thing we've discussed with @slonka to enable a progressive move is to have a workflow that waits for circleci checks to be green.
This way downstream automation can rely on this and we can progressively move things from circleCI to GH actions by extending this workflow.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 22, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label May 30, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 29, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Aug 29, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 28, 2023
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Nov 28, 2023
@michaelbeaumont
Copy link
Contributor

I guess @jijiechen you're working on this? Duplicate issue or still useful? @lahabana

@jijiechen
Copy link
Member

Closing this as we've done this by a few PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

5 participants